Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (riscv) RiscvRegisterQueue makes empty queue, add helper #4060

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

superlopuh
Copy link
Member

As a step towards a generic register queue, I wanted to decouple the init from the ABI default available and reserved registers.

@superlopuh superlopuh added the backend Compiler backend in xDSL label Mar 14, 2025
@superlopuh superlopuh self-assigned this Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.04%. Comparing base (b85f63b) to head (d415ce9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/backend/riscv/riscv_register_queue.py 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4060   +/-   ##
=======================================
  Coverage   89.03%   89.04%           
=======================================
  Files         317      317           
  Lines       43338    43351   +13     
  Branches     5403     5407    +4     
=======================================
+ Hits        38588    38601   +13     
+ Misses       3407     3406    -1     
- Partials     1343     1344    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in my mind these live in a separate dialect, but this is a good interim step.

@superlopuh superlopuh merged commit a69ff88 into main Mar 14, 2025
18 checks passed
@superlopuh superlopuh deleted the sasha/regalloc/dict-queue branch March 14, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants