documentation: migrate interoperability notebook from jupyter to marimo #4059
+206
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I didn't catch it in the workflow file. Fixing. |
compor
force-pushed
the
christos/docs/migrate-interop-notebook-to-marimo
branch
from
702e231 to
137a0f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4059 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 318 318
Lines 43402 43402
Branches 5402 5402
=======================================
Hits 38649 38649
Misses 3409 3409
Partials 1344 1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superlopuh
reviewed
Mar 20, 2025
| @@ -94,7 +93,14 @@ tests-marimo: uv-installed | |||
| @bash -c '\ | |||
| error_log="/tmp/marimo_test_$$$$.log"; \ | |||
| failed_tests=""; \ | |||
| skip_files=("docs/marimo/mlir_interoperation.py"); \ | |||
There was a problem hiding this comment.
these are conditionally skipped, right? Maybe call this mlir_opt_files?
superlopuh
reviewed
Mar 20, 2025
| @@ -117,7 +117,7 @@ jobs: | |||
| cd xdsl | |||
| # Add mlir-opt to the path | |||
| export PATH=$PATH:${GITHUB_WORKSPACE}/llvm-project/build/bin/ | |||
| uv run pytest --nbval docs/mlir_interoperation.ipynb --maxfail 1 -vv | |||
| uv run python3 docs/marimo/mlir_interoperation.py | |||
There was a problem hiding this comment.
?
Suggested change
| uv run python3 docs/marimo/mlir_interoperation.py | |
| make tests-marimo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: