Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: spelling -> register_name #4021

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

superlopuh
Copy link
Member

As noted by Chris in #4020 (comment), spelling is not the ideal name for the concept. name is already taken, so I propose register_name. We already have a helper that returns a str called register_name, which I propose to just remove.

@superlopuh superlopuh added the backend Compiler backend in xDSL label Mar 5, 2025
@superlopuh superlopuh self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (b58cfb8) to head (add4fbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         458      458              
  Lines       58341    58337       -4     
  Branches     5692     5692              
==========================================
- Hits        52620    52616       -4     
  Misses       4331     4331              
  Partials     1390     1390              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@superlopuh superlopuh merged commit d79fec8 into main Mar 6, 2025
17 checks passed
@superlopuh superlopuh deleted the sasha/registers/register-name branch March 6, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants