documentation: remove database example notebook #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just re-read it, and it's so far gone from being correct that it's kind of impressive. It mentions things that we talk about in our existing marimo notebooks, so I don't think we need to move any of the contents.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 458 458
Lines 58288 58288
Branches 5687 5687
=======================================
Hits 52570 52570
Misses 4328 4328
Partials 1390 1390 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just re-read it, and it's so far gone from being correct that it's kind of impressive. I accept all responsibility for making changes to the API that have resulted in the final module not making sense.
It mentions things that we talk about in our existing marimo notebooks, so I don't think we need to move any of the contents.