Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: make xDSL version getting lazy #4012

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

superlopuh
Copy link
Member

This was just annoying me when looking at traces, we pay the cost of the version function even when we're not going to use it (6ms on my laptop).

This was just annoying me when looking at traces, we pay the cost of the version function even when we're not going to use it (6ms on my laptop).
@superlopuh superlopuh added minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Mar 3, 2025
@superlopuh superlopuh self-assigned this Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (c9493b7) to head (1433189).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4012   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         458      458           
  Lines       58288    58294    +6     
  Branches     5687     5687           
=======================================
+ Hits        52570    52577    +7     
  Misses       4328     4328           
+ Partials     1390     1389    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit 0407ec8 into main Mar 4, 2025
17 checks passed
@superlopuh superlopuh deleted the sasha/misc/lazy-version branch March 4, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants