-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: (affine) Add Affine.binary #4006
core: (affine) Add Affine.binary #4006
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4006 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 458 458
Lines 58409 58455 +46
Branches 5691 5697 +6
==========================================
+ Hits 52707 52747 +40
- Misses 4320 4323 +3
- Partials 1382 1385 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
While implementing this I realized that when composing two affine maps the expressions are not automatically simplified/constant folded. |
What does MLIR do here? I have a suspicion that they constant fold when creating the affine expr, it would be worth doing the same in xDSL. I can't find these helpers in the AffineExpr and AffineMap header files. |
MLIR simplifies while composing. This is the call stack, the simplification happens at the last call:
|
Added |
Remove compose_with_values function as it is in essence the same as eval
Cherry picked from #3650. Prerequisite for implementing
vector.transfer_read
andvector.transfer_write
ops