Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: split InferenceContext dictionaries #4000

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

superlopuh
Copy link
Member

When inferring, we know which dictionary to look into, same for when we construct the InferenceContext, so we might as well split it. PR-1 to using the ConstraintContext during inference.

@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Mar 2, 2025
@superlopuh superlopuh self-assigned this Mar 2, 2025
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (261d757) to head (537c67d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4000   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files         458      458           
  Lines       58298    58312   +14     
  Branches     5691     5694    +3     
=======================================
+ Hits        52567    52580   +13     
  Misses       4340     4340           
- Partials     1391     1392    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we could consider trying to split up the extractors but that would be a larger change

@superlopuh
Copy link
Member Author

You have foretold the future 🔮

@superlopuh superlopuh merged commit 30248fd into main Mar 2, 2025
17 checks passed
@superlopuh superlopuh deleted the sasha/ird/split-inference-context branch March 2, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants