misc: store context as property on ParsingState

[superlopuh]

Makes it more explicit that the variable contains all the state necessary for inference.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (b6caa5f) to head (13cacf6).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3997   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         458      458           
  Lines       58291    58298    +7     
  Branches     5691     5691           
=======================================
+ Hits        52559    52566    +7     
  Misses       4340     4340           
  Partials     1392     1392           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexarice]

I'm unsure if this change is sound with InferenceContext being mutable. If it's only something we use internally then it's probably fine

[superlopuh]

Aren't they both just as mutable as each other?

[alexarice]

True, I for some reason thought we were copying it when making the context but we obviously weren't

[alexarice]

Could you remind me of the reason for the InferenceContext. Do we expect other things to be in there?

[superlopuh]

That's the next PR!

[superlopuh]

I'm actually going towards using the ConstraintContext for inference again.

[alexarice]

I feel context is a slightly ambiguous name but I'm getting the feeling that this is part of a bigger change that may make it make more sense

[superlopuh]

Yeah it's InferenceContext in this PR but will be a ConstraintContext in a future one.