Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: move coverage config to pyproject.toml #3959

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

superlopuh
Copy link
Member

Just a bit of simplification to the project, moving the config to one place instead of spreading it across multiple files.

@superlopuh superlopuh added the testing PRs that modify tests label Feb 24, 2025
@superlopuh superlopuh self-assigned this Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (009599d) to head (05fa75e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3959      +/-   ##
==========================================
+ Coverage   88.59%   90.13%   +1.54%     
==========================================
  Files         320      458     +138     
  Lines       43397    58347   +14950     
  Branches     5419     5706     +287     
==========================================
+ Hits        38449    52593   +14144     
- Misses       3580     4349     +769     
- Partials     1368     1405      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried this a while back, but coverage didn't support pyproject.toml; cool that they added support

pyproject.toml Outdated
]
concurrency = ["multiprocessing"]
parallel = true
source = ["xdsl/", "tests/", "docs/"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we just remove tests/ in the other PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I've just merged that one, will remove tests from here before I merge

@superlopuh superlopuh merged commit 3c4c6f7 into main Feb 25, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/testing/coveragerc branch February 25, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing PRs that modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants