Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: (pdl) add operations directly in pdl.operation #3949

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

jumerckx
Copy link
Collaborator

@jumerckx jumerckx commented Feb 22, 2025

reference: #3862 (comment)
Operations are now inserted directly when interpreting pdl.operation. Insertion happens right before the root of the rewrite op.

Fixes #3569

@jumerckx jumerckx added the interpreter xDSL Interpreter label Feb 22, 2025
@jumerckx jumerckx requested a review from superlopuh February 22, 2025 18:30
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (2873a9c) to head (c77daf0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3949   +/-   ##
=======================================
  Coverage   91.30%   91.31%           
=======================================
  Files         467      467           
  Lines       58068    58091   +23     
  Branches     5581     5581           
=======================================
+ Hits        53021    53044   +23     
  Misses       3616     3616           
  Partials     1431     1431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It would be great to add a test here, hopefully something that failed before, and no longer fails with these changes. Ideally a pdl-interp lit test, as well as a pytest test. I'm happy to help out with either!

@jumerckx
Copy link
Collaborator Author

This is great! It would be great to add a test here, hopefully something that failed before, and no longer fails with these changes. Ideally a pdl-interp lit test, as well as a pytest test. I'm happy to help out with either!

I'll look into it!

jumerckx and others added 3 commits February 23, 2025 19:16
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@jumerckx jumerckx requested a review from superlopuh February 23, 2025 20:32
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@superlopuh superlopuh merged commit f4f7028 into main Feb 24, 2025
16 checks passed
@superlopuh superlopuh deleted the jumerckx/pdl branch February 24, 2025 09:44
qaco pushed a commit to qaco/xdsl that referenced this pull request Feb 24, 2025
…oject#3949)

Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter xDSL Interpreter
Projects
Development

Successfully merging this pull request may close these issues.

interpreter: (pdl) fix multiple inserted operations in rewrite pattern interpreter
2 participants