-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interpreter: (pdl) add operations directly in pdl.operation
#3949
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3949 +/- ##
=======================================
Coverage 91.30% 91.31%
=======================================
Files 467 467
Lines 58068 58091 +23
Branches 5581 5581
=======================================
+ Hits 53021 53044 +23
Misses 3616 3616
Partials 1431 1431 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! It would be great to add a test here, hopefully something that failed before, and no longer fails with these changes. Ideally a pdl-interp
lit test, as well as a pytest test. I'm happy to help out with either!
I'll look into it! |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…oject#3949) Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
reference: #3862 (comment)
Operations are now inserted directly when interpreting
pdl.operation
. Insertion happens right before the root of the rewrite op.Fixes #3569