CI: fix RUN command in fsm and ltl lit tests #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
alexarice,
math-fehr and
luisacicolini
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
=======================================
Coverage 91.30% 91.31%
=======================================
Files 467 467
Lines 58068 58068
Branches 5581 5581
=======================================
+ Hits 53021 53025 +4
Misses 3616 3616
+ Partials 1431 1427 -4 ☔ View full report in Codecov by Sentry. |
|
wdym? |
compor
approved these changes
Feb 24, 2025
|
I've got a branch locally that changes the lit config that detected these files, still need to make a few changes to make sure everything works properly but will open soon. |
qaco
pushed a commit
to qaco/xdsl
that referenced
this pull request
Feb 24, 2025
superlopuh
added a commit
that referenced
this pull request
Mar 13, 2025
This change in configuration was motivated by the lack of detection of missing `__init__.py` files in the project. We now have a ruff check for this (#3945), but in my changing the config, I found a number of other issues stemming from the `cd ../..` in the preamble to the tests. One is that for some reason files with no RUN lines aren't detected with the preamble. I fixed the broken tests that weren't run in a separate PR (#3944), so this is just about making the config change and making minor fixes to remaining files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The good news is that in the near future this will be detected automatically.