Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: (x86) always remove the register/memory prefix from the emitted assembly #3924

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

qaco
Copy link
Collaborator

@qaco qaco commented Feb 17, 2025

The printer should not emit code like rr.add, but our Python filecheck implementation only checks substrings (even when the dedicated knob is on). I fix the emitter to make it usable but a long-term solution is either to fix the Python filecheck reimplementation or to py-package LLVM filecheck.

@qaco qaco added bug Something isn't working dialects Changes on the dialects labels Feb 17, 2025
@qaco qaco self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (38089d6) to head (8bfce1b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3924      +/-   ##
==========================================
- Coverage   91.31%   91.30%   -0.01%     
==========================================
  Files         467      467              
  Lines       58108    58068      -40     
  Branches     5579     5581       +2     
==========================================
- Hits        53060    53021      -39     
+ Misses       3618     3616       -2     
- Partials     1430     1431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor compor changed the title bug: (x86) always remove the register/memory preffix from the emitted assembly bug: (x86) always remove the register/memory prefix from the emitted assembly Feb 17, 2025
qaco and others added 2 commits February 17, 2025 19:20
@qaco qaco merged commit 5cf9f7d into xdslproject:main Feb 17, 2025
16 checks passed
@qaco qaco deleted the hugo/assembly-preffixes branch February 17, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants