Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: (x86) fix assembly when the offset of a memory access is 0 #3888

Merged
merged 7 commits into from
Feb 12, 2025
Merged

backend: (x86) fix assembly when the offset of a memory access is 0 #3888

merged 7 commits into from
Feb 12, 2025

Conversation

qaco
Copy link
Collaborator

@qaco qaco commented Feb 11, 2025

No description provided.

@qaco qaco added dialects Changes on the dialects backend Compiler backend in xDSL labels Feb 11, 2025
@qaco qaco self-assigned this Feb 11, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (12f4619) to head (c3bd3dd).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3888      +/-   ##
==========================================
- Coverage   91.26%   91.25%   -0.01%     
==========================================
  Files         466      466              
  Lines       57905    57945      +40     
  Branches     5570     5575       +5     
==========================================
+ Hits        52845    52879      +34     
- Misses       3634     3635       +1     
- Partials     1426     1431       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qaco qaco force-pushed the hugo/fix_offset_zero branch from 1a81a62 to 6da03c1 Compare February 12, 2025 13:28
@qaco qaco merged commit 941bf19 into xdslproject:main Feb 12, 2025
16 checks passed
oluwatimilehin pushed a commit to oluwatimilehin/xdsl that referenced this pull request Feb 13, 2025
@qaco @oluwatimilehin
backend: (x86) fix assembly when the offset of a memory access is 0 (x…
0bbb74f 
…dslproject#3888)
@qaco qaco deleted the hugo/fix_offset_zero branch February 17, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compor compor compor approved these changes

@superlopuh superlopuh superlopuh approved these changes

@emmau678 emmau678 Awaiting requested review from emmau678

Assignees

@qaco qaco

Labels
backend Compiler backend in xDSL dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qaco @superlopuh @compor