dialects: (linalg) enable generic printing in mlir conversion filecheck #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2025
jorendumoulin
commented
Feb 5, 2025
Comment on lines
1
to
+2
| // RUN: xdsl-opt %s | xdsl-opt | mlir-opt --allow-unregistered-dialect | filecheck %s | ||
| // RUN: xdsl-opt %s | xdsl-opt --print-op-generic | mlir-opt --allow-unregistered-dialect | filecheck %s |
There was a problem hiding this comment.
This is the only change in this PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3837 +/- ##
==========================================
- Coverage 91.26% 91.26% -0.01%
==========================================
Files 461 461
Lines 57658 57658
Branches 5570 5570
==========================================
- Hits 52624 52622 -2
- Misses 3611 3612 +1
- Partials 1423 1424 +1 ☔ View full report in Codecov by Sentry. |
jorendumoulin
added a commit
that referenced
this pull request
Feb 5, 2025
This adds a hidden region to the linalg.transpose op to ensure correct generic printing Also changes permutation to a property instead of attribute. This resolves the transpose op in #2959 This has now been checked manually, and will be put in ci with #3837 (but for that 3 other ops need to be fixed, PRs incoming...)
jorendumoulin
added a commit
that referenced
this pull request
Feb 5, 2025
jorendumoulin
added a commit
that referenced
this pull request
Feb 5, 2025
jorendumoulin
force-pushed
the
joren/linalg/enable-filecheck
branch
from
cd7e495 to
c39ed43
Compare
compor
approved these changes
Feb 5, 2025
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
This adds a hidden region to the linalg.transpose op to ensure correct generic printing Also changes permutation to a property instead of attribute. This resolves the transpose op in #2959 This has now been checked manually, and will be put in ci with #3837 (but for that 3 other ops need to be fixed, PRs incoming...)
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
…ck (#3837) This PR adds generic printing to the mlir conversion filecheck This will check whether the issues posed in #2959 are correctly resolved, by checking if mlir correctly parses the generic output of xdsl There are still reminaing issues, solved in the following PRs: (stacked on: ) #3838, #3839, #3840, #3841
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
This adds a hidden region to the linalg.transpose op to ensure correct generic printing Also changes permutation to a property instead of attribute. This resolves the transpose op in xdslproject#2959 This has now been checked manually, and will be put in ci with xdslproject#3837 (but for that 3 other ops need to be fixed, PRs incoming...)
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
…project#3839) To enable correct printing of the hidden regions in generic printing. Resolves pooling in xdslproject#2959 , will be tested in xdslproject#3837 The constructor of these ops had to change to comply with the NamedOpBase constructor ordering of arguments
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
Resolves pooling in xdslproject#2959 , will be tested in xdslproject#3837
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
…ject#3841) This enables to correct printing of the hidden regions in generic format Resolves conv ops in xdslproject#2959, will be tested with xdslproject#3837
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
…ck (xdslproject#3837) This PR adds generic printing to the mlir conversion filecheck This will check whether the issues posed in xdslproject#2959 are correctly resolved, by checking if mlir correctly parses the generic output of xdsl There are still reminaing issues, solved in the following PRs: (stacked on: ) xdslproject#3838, xdslproject#3839, xdslproject#3840, xdslproject#3841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds generic printing to the mlir conversion filecheck
This will check whether the issues posed in #2959 are correctly resolved, by checking if mlir correctly parses the generic output of xdsl
There are still reminaing issues, solved in the following PRs:
(stacked on: ) #3838, #3839, #3840, #3841