misc: simplify setup.py #3815
Merged
misc: simplify setup.py #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
alexarice,
georgebisbas,
math-fehr and
webmiche
superlopuh
commented
Feb 1, 2025
| cmdclass=cast(Mapping[str, type[Command]], versioneer.get_cmdclass()), | ||
| packages=find_packages(), | ||
| version=versioneer.get_version(), | ||
| cmdclass=versioneer.get_cmdclass(), |
There was a problem hiding this comment.
this is well typed now
superlopuh
commented
Feb 1, 2025
| @@ -57,6 +57,7 @@ xdsl-tblgen = "xdsl.tools.tblgen_to_py:main" | |||
| [tool.setuptools] | |||
| platforms = ["Linux", "Mac OS-X", "Unix"] | |||
| zip-safe = false | |||
| packages = ["xdsl"] | |||
There was a problem hiding this comment.
we only have one package, no need to auto-discover things
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3815 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 461 461
Lines 57557 57557
Branches 5549 5549
=======================================
Hits 52523 52523
Misses 3609 3609
Partials 1425 1425 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Feb 1, 2025
math-fehr
approved these changes
Feb 1, 2025
kaylendog
added a commit
to kaylendog/xdsl
that referenced
this pull request
Feb 3, 2025
This reverts commit 27bf821.
|
This has completely broken downstream |
This was referenced Feb 5, 2025
superlopuh
added a commit
that referenced
this pull request
Feb 10, 2025
Reopens #3848, which fixes a regression introduced by #3815, and partially fixed with #3847. While the issue is fixed on most installations with the other fix PR it breaks on some systems, and when a `site` folder is present after generating the docs website locally. We tested this change with @georgebisbas today, on whose linux machine xDSL cannot currently be installed, and works after applying the changes in this PR.
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
oluwatimilehin
pushed a commit
to oluwatimilehin/xdsl
that referenced
this pull request
Feb 13, 2025
Reopens xdslproject#3848, which fixes a regression introduced by xdslproject#3815, and partially fixed with xdslproject#3847. While the issue is fixed on most installations with the other fix PR it breaks on some systems, and when a `site` folder is present after generating the docs website locally. We tested this change with @georgebisbas today, on whose linux machine xDSL cannot currently be installed, and works after applying the changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of simplification. I tried to remove the whole thing but versioneer breaks.