dialects: (builtin) add support for IntegerType packing with arbitrary bitwidth up to 64 #3728
Conversation
|
While the bug I hit was with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 468 468
Lines 58601 58611 +10
Branches 5656 5656
=======================================
+ Hits 53492 53502 +10
Misses 3659 3659
Partials 1450 1450 ☔ View full report in Codecov by Sentry. |
|
Can we not just store each integer in |
|
yes, I think that makes sense. for larger than 64 bits we would need something else than struct.pack however |
jorendumoulin
changed the title
it should be ceil(bitwidth/8) though |
To answer my own question, apparently python ints are at least 28 bytes |
xdsl/dialects/builtin.py
Outdated
| @@ -532,14 +532,14 @@ def print_value_without_type(self, value: int, printer: Printer): | |||
|
|
|||
| @property | |||
| def format(self) -> str: | |||
| match self.bitwidth: | |||
| case 1 | 8: | |||
| match -(self.bitwidth // -8): # ceildiv | |||
There was a problem hiding this comment.
?
| match -(self.bitwidth // -8): # ceildiv | |
| match (self.bitwidth - 1) >> 3: |
There was a problem hiding this comment.
(7 + self.bitwidth) >> 3 works I think
There was a problem hiding this comment.
(self.bitwidth + 7) >> 3 is also used on L389 to compute the byte size of a FixedBitWidthType, so i think that one makes sense
No description provided.