dialects: (builtin) make FloatAttr a TypedAttribute #3488
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3488 +/- ##
=======================================
Coverage 90.31% 90.32%
=======================================
Files 462 462
Lines 58040 58076 +36
Branches 5563 5565 +2
=======================================
+ Hits 52419 52455 +36
Misses 4188 4188
Partials 1433 1433 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Would it be worth factoring out a |
alexarice
force-pushed
the
alexarice/float-typed
branch
from
74635f8 to
31546f7
Compare
alexarice
changed the base branch from
main
to
alexarice/typed-attribute-printing
|
I've refactored and rebased on top of #3490 |
xdsl/parser/base_parser.py
Outdated
| def parse_optional_float( | ||
| self, | ||
| *, | ||
| allow_negative: bool = False, |
There was a problem hiding this comment.
I can imagine this being quite confusing, let's drop the default argument for now?
There was a problem hiding this comment.
It was copied off the above function for integers I think, but sounds like a good idea
There was a problem hiding this comment.
It seems I copied poorly and the rest have a default value of True, would that be preferred or still no default?
There was a problem hiding this comment.
I have a slight preference towards default True
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Pretty much as the title says.