dialects: (riscv) split out the base classes for custom format and assembly printing #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
compor,
zero9178,
AntonLydike,
alexarice and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 458 458
Lines 57716 57717 +1
Branches 5564 5564
=======================================
+ Hits 52059 52060 +1
Misses 4194 4194
Partials 1463 1463 ☔ View full report in Codecov by Sentry. |
zero9178
approved these changes
Nov 13, 2024
alexarice
reviewed
Nov 13, 2024
xdsl/dialects/riscv.py
Outdated
| @@ -361,6 +361,12 @@ def get_register_constraints(self) -> RegisterConstraints: | |||
| def assembly_line(self) -> str | None: | |||
| raise NotImplementedError() | |||
|
|
|||
|
|
|||
| class RISCVCustomFormatOperation(RISCVAsmOperation, ABC): | |||
There was a problem hiding this comment.
Is it intentional that this inherits from RISCVAsmOperation? Your description makes it sound like these should be disjoint
There was a problem hiding this comment.
Ah yes I'll remove this, thank you
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…sembly printing (xdslproject#3436) We currently have a single base class for two kinds of shared functionality: printing the assembly for the target, and printing the custom format. I'd like to decouple them to migrate some RISC-V operations to custom format, which cannot be provided at the same time as custom printing and parsing functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a single base class for two kinds of shared functionality: printing the assembly for the target, and printing the custom format. I'd like to decouple them to migrate some RISC-V operations to custom format, which cannot be provided at the same time as custom printing and parsing functions.