dialects (scf): Canonicalization for const rehoisting #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamanain
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3421 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 455 455
Lines 57467 57509 +42
Branches 5532 5536 +4
=======================================
+ Hits 51815 51854 +39
- Misses 4195 4196 +1
- Partials 1457 1459 +2 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Nov 11, 2024
Comment on lines
26
to
27
| rewriter.insert_op_before_matched_op([new_const := child_op.clone()]) | ||
| rewriter.replace_op(child_op, [], new_const.results) |
There was a problem hiding this comment.
nit:
Suggested change
| rewriter.insert_op_before_matched_op([new_const := child_op.clone()]) | |
| rewriter.replace_op(child_op, [], new_const.results) | |
| rewriter.insert_op_before_matched_op((new_const := child_op.clone(),)) | |
| rewriter.replace_op(child_op, (), new_const.results) |
| @@ -1,4 +1,4 @@ | |||
| // RUN: xdsl-opt -p canonicalize %s | filecheck %s | |||
| // RUN: xdsl-opt -p canonicalize --split-input-file %s | filecheck %s | |||
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
We want to carry out constant definition from loop definition to allow more loop optimizations. In mlir this is done in cse on constants inside the `applyPatternsAndFoldGreedily` function in the PatternRewriter. In the future we might port this functionality so this pattern will become redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to carry out constant definition from loop definition to allow more loop optimizations. In mlir this is done in cse on constants inside the
applyPatternsAndFoldGreedilyfunction in the PatternRewriter. In the future we might port this functionality so this pattern will become redundant.