dialects: llvm fixed parsing of nested structs #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3369 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 450 450
Lines 56820 56822 +2
Branches 5459 5460 +1
=======================================
+ Hits 51209 51211 +2
Misses 4167 4167
Partials 1444 1444 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Oct 31, 2024
|
|
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
Fixes xdslproject#810 The problem were nested structs. The `!llvm` prefixes are omitted for inner structs by mlir-opt, even when using `--mlir-print-op-generic` format. Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810
The problem were nested structs.
The
!llvmprefixes are omitted for inner structs by mlir-opt, even when using--mlir-print-op-genericformat.