Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (pdl) Filecheck test documenting how to match an MLIR operation without return type #3358

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

qaco
Copy link
Collaborator

@qaco qaco commented Oct 30, 2024

Filecheck test documenting how to match an MLIR operation without return type

@qaco qaco added the dialects Changes on the dialects label Oct 30, 2024
@qaco qaco requested a review from superlopuh October 30, 2024 15:46
@qaco qaco self-assigned this Oct 30, 2024
@superlopuh
Copy link
Member

This looks good but I'm not sure what the purpose is. Is it documentation, or to make sure that we don't break this syntax in the future?

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (21b6a60) to head (95895a7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3358      +/-   ##
==========================================
+ Coverage   90.06%   90.09%   +0.03%     
==========================================
  Files         447      447              
  Lines       56532    56578      +46     
  Branches     5425     5431       +6     
==========================================
+ Hits        50915    50975      +60     
+ Misses       4184     4166      -18     
- Partials     1433     1437       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qaco
Copy link
Collaborator Author

qaco commented Oct 30, 2024

This looks good but I'm not sure what the purpose is. Is it documentation, or to make sure that we don't break this syntax in the future?

Both. Since the explicit syntax with -> () is also intuitive but not yet implemented, this test shows - and guarantees - that there is a correct way to program this behavior. This saves the person who needs it from having to hack the parser for nothing.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you!

@superlopuh superlopuh merged commit 4040e03 into xdslproject:main Oct 30, 2024
14 checks passed
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
…tion without return type (xdslproject#3358)

Filecheck test documenting how to match an MLIR operation without return
type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants