core: default props should always be added #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 445 445
Lines 56166 56170 +4
Branches 5390 5390
=======================================
+ Hits 50571 50575 +4
Misses 4179 4179
Partials 1416 1416 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Oct 16, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
I messed up slightly on the default properties. It seems that the default should be inserted even when using the generic syntax. I've moved the default logic to `__post_init__` so that it triggers for all `Operation`s and added a test to clarify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up slightly on the default properties. It seems that the default should be inserted even when using the generic syntax. I've moved the default logic to
__post_init__so that it triggers for allOperations and added a test to clarify.