dialects: (llvm) Add support for overflow flags #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
==========================================
+ Coverage 89.99% 90.02% +0.02%
==========================================
Files 445 445
Lines 55749 55898 +149
Branches 5367 5353 -14
==========================================
+ Hits 50173 50321 +148
- Misses 4166 4169 +3
+ Partials 1410 1408 -2 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Oct 11, 2024
Comment on lines
8
to
18
| %add_nuw = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nuw>} : i32 | ||
| // CHECK: %add_nuw = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nuw>} : i32 | ||
|
|
||
| %sub = llvm.sub %arg0, %arg1 : i32 | ||
| // CHECK: %sub = llvm.sub %arg0, %arg1 : i32 | ||
| %add_none = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<none>} : i32 | ||
| // CHECK: %add_none = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<none>} : i32 | ||
|
|
||
| %mul = llvm.mul %arg0, %arg1 : i32 | ||
| // CHECK: %mul = llvm.mul %arg0, %arg1 : i32 | ||
| %add_both = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nsw, nuw>} : i32 | ||
| // CHECK: %add_both = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nsw,nuw>} : i32 | ||
|
|
||
| %udiv = llvm.udiv %arg0, %arg1 : i32 | ||
| // CHECK: %udiv = llvm.udiv %arg0, %arg1 : i32 | ||
| %add_both_reverse = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nuw, nsw>} : i32 | ||
| // CHECK: %add_both_reverse = llvm.add %arg0, %arg1 {"overflowFlags" = #llvm.overflow<nsw,nuw>} : i32 |
There was a problem hiding this comment.
I think we should be safe to remove these, the tests below with the custom syntax cover it enough, IMO
There was a problem hiding this comment.
Okay
I still kept one test with the complete syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.