Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (riscv) canonize x ^ x = 0 #3121

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

mamanain
Copy link
Collaborator

Hello! Canonizing this pattern.

Should it be just li 0 instead of it's canonized form in the rewrite pattern? In this case it kind of seems like canonization of li 0 is split to two places.

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (56ec030) to head (b0bfc71).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3121   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files         425      425           
  Lines       53379    53391   +12     
  Branches     8267     8268    +1     
=======================================
+ Hits        47995    48006   +11     
  Misses       4047     4047           
- Partials     1337     1338    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@superlopuh superlopuh added the dialects Changes on the dialects label Aug 31, 2024
@superlopuh superlopuh merged commit 30dcaa1 into xdslproject:main Aug 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants