transformations: Enable bufferized dmp.swap lowering.
#3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement side effect interface of dmp.swap - Slightly extend the side-effect analysis of stencil bufferization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.01%
==========================================
Files 416 416
Lines 52499 52505 +6
Branches 8128 8128
==========================================
+ Hits 47182 47183 +1
- Misses 4007 4012 +5
Partials 1310 1310 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Aug 20, 2024
|
I missed this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
dmp-to-mpiexpected to run right before stencil lowering, as opposed to right after!Mostly because of my brutal type conversion for stencil.
But I don't think I'll have time for a finer type conversion infrastructure soon, and this makes things work in Devito!