Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (csl_stencil) Add bufferization pass #3004

Merged
merged 16 commits into from
Aug 13, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Aug 9, 2024

Change stencil.field to memrefs, change all tensors to memrefs, and perform a 'partial bufferization' by inserting bufferization.to_tensor and bufferization.to_memref ops where needed to that other dialects can still operate on tensors.

Todo:

  • fix verification
  • add docstrings
  • review setting of restrict, writable, and read_only of the bufferization ops
  • add extract_slice needed by linalg bufferize

Edit: I think I re-used a branch name of a merged branch, ignore some of the commits

@n-io n-io requested review from PapyChacal and dk949 August 9, 2024 17:07
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (30446fe) to head (7619c61).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   89.83%   89.85%   +0.02%     
==========================================
  Files         411      412       +1     
  Lines       51674    51816     +142     
  Branches     8034     8064      +30     
==========================================
+ Hits        46419    46557     +138     
+ Misses       3970     3968       -2     
- Partials     1285     1291       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

Can you please assign yourself and add the appropriate labels?

@n-io n-io self-assigned this Aug 12, 2024
@n-io n-io added the transformations Changes or adds a transformatio label Aug 12, 2024
@n-io n-io requested a review from AntonLydike August 12, 2024 12:34
@n-io n-io requested a review from PapyChacal August 13, 2024 10:30
Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not getting all semantics used so just reviewed the code itself!

@n-io n-io merged commit 24693c8 into main Aug 13, 2024
10 checks passed
@n-io n-io deleted the nicolai/bufferize-csl-stencil branch August 13, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants