This repository was archived by the owner on Aug 12, 2024. It is now read-only.
#12 Make ChipCombobox Vaadin conform, add Setters #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AB-xdev
suggested changes
Jul 7, 2021
vaadin-chip-combobox/src/main/java/software/xdev/vaadin/chips/ChipComboBox.java
Outdated
Show resolved
Hide resolved
vaadin-chip-combobox/src/main/java/software/xdev/vaadin/chips/ChipComboBox.java
Outdated
Show resolved
Hide resolved
vaadin-chip-combobox/src/main/java/software/xdev/vaadin/chips/ChipComboBox.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Changes should be corrected now |
Member
|
LGTM; |
AB-xdev
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
This PR implements the changes as requested in issue #12. I've added three new Setters (including the ones required from the HasItems interface), which call the matching methods that already existed previously.
setLabel(String)callsthis.withLabel(String)setPlaceholder(String)callsthis.withPlaceholder(String)setItems(Collection<T>)callsthis.withAllAvailableItems(ArrayList<T>, true)