Update CMake minimum required version to 3.10 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 4 removed compatibility with CMake versions < 3.5, and versions between 3.5-3.10 are deprecated. This change updates the minimum required version to 3.10 to ensure compatibility with modern CMake versions including CMake 4.x. This issue is affecting NixOS users (see NixOS/nixpkgs#450274) and will likely impact other distributions as they upgrade to CMake 4.x.
This was referenced Oct 9, 2025
Daviey
added a commit
to Daviey/nixpkgs
that referenced
this pull request
Oct 9, 2025
Replaces the postPatch workaround from NixOS#449882 with a proper patch file. The patch approach is better because when the fix is merged upstream and we update the version, the patch will fail to apply, giving us a clear signal to remove it. With postPatch, the substitution would continue to work silently even after upstream fixes it, causing us to carry unnecessary delta forever. Patches CMakeLists.txt to require CMake 3.10 instead of 2.8. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated. Upstream PR: xdbob/xss-lock#3 Fixes: NixOS#450274 Signed-off-by: Dave Walker <dave@daviey.com>
work-jdannenberg
pushed a commit
to work-jdannenberg/nixpkgs
that referenced
this pull request
Oct 10, 2025
Replaces the postPatch workaround from NixOS#449882 with a proper patch file. The patch approach is better because when the fix is merged upstream and we update the version, the patch will fail to apply, giving us a clear signal to remove it. With postPatch, the substitution would continue to work silently even after upstream fixes it, causing us to carry unnecessary delta forever. Patches CMakeLists.txt to require CMake 3.10 instead of 2.8. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated. Upstream PR: xdbob/xss-lock#3 Fixes: NixOS#450274 Signed-off-by: Dave Walker <dave@daviey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 4 removed compatibility with CMake versions < 3.5, and versions between 3.5-3.10 are deprecated.
This change updates the minimum required version to 3.10 to ensure compatibility with modern CMake versions including CMake 4.x.
This issue is affecting NixOS users (see NixOS/nixpkgs#450274) and will likely impact other distributions as they upgrade to CMake 4.x.
The error message when using CMake 4.x: