Choose a local SR that was already in the pool before the tests #363
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormi
approved these changes
Nov 18, 2025
stormi
requested changes
Nov 18, 2025
Member
stormi
left a comment
stormi
left a comment
There was a problem hiding this comment.
The commit message must describe what the problem was.
glehmann
force-pushed
the
gln/local-sr-selection-ouko
branch
from
f706e0a to
13db638
Compare
stormi
approved these changes
Nov 19, 2025
glehmann
force-pushed
the
gln/local-sr-selection-ouko
branch
from
13db638 to
50f1d28
Compare
rzr
approved these changes
Nov 24, 2025
rzr
left a comment
rzr
left a comment
There was a problem hiding this comment.
Sounds fair enough, but it may have impact on the reproducibility of test
Nambrok
requested changes
Nov 24, 2025
lib/host.py
Outdated
| ) | ||
| # We don't want a SR added by the test, so choose one that already existed | ||
| pre_existing_local_sr_uuids = sorted(set(self.pool.pre_existing_sr_uuids) & set(local_sr_uuids)) | ||
| assert local_sr_uuids, f"DEFAULT_SR=='local' so there must be a local SR on host {self}" |
Contributor
There was a problem hiding this comment.
You should update the assert here to use pre_existing_local_sr_uuids
glehmann
force-pushed
the
gln/local-sr-selection-ouko
branch
from
50f1d28 to
b7dac3e
Compare
The test may create a local SR that should be used only for the test. Using it for something else, like caching the VMs, it prevents the SR being destroyed in the tear down. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/local-sr-selection-ouko
branch
from
b7dac3e to
e44e6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.