Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: store HTML coverage report #1

Merged
merged 1 commit into from
Aug 22, 2023
Merged

ci: store HTML coverage report #1

merged 1 commit into from
Aug 22, 2023

Conversation

ydirson
Copy link
Contributor

@ydirson ydirson commented Aug 22, 2023

  • use grcov over llvmcov for simplicity and ability to reuse results (?)
  • upload as artifact and not to codecov.io
  • split test and build into separate jobs, so failed tests do not appear as failing the build, and allowing to use a nightly toolchain for tests while still building with stable toolchain
  • use more standard actions-rs/toolchain to support nightly builds

@ydirson
ci: store HTML coverage report
31b177b 
- use grcov over llvmcov for simplicity and ability to reuse results (?)
- upload as artifact and not to codecov.io
- split test and build into separate jobs, so failed tests do not appear
  as failing the build, and allowing to use a nightly toolchain for
  tests while still building with stable toolchain
- use more standard actions-rs/toolchain to support nightly builds
@ydirson ydirson requested a review from TSnake41 August 22, 2023 11:31
TSnake41
TSnake41 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@TSnake41 TSnake41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste noter que ça exige le Rust nightly pour les tests avec profile.

@ydirson
Copy link
Contributor Author

ydirson commented Aug 22, 2023

Juste noter que ça exige le Rust nightly pour les tests avec profile.

Fair enough but ⚠️ 🥖

@TSnake41 TSnake41 merged commit fb91f25 into main Aug 22, 2023
4 of 5 checks passed
@ydirson ydirson deleted the ydi/grcov-html branch August 22, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSnake41 TSnake41 TSnake41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydirson @TSnake41