update to ts-eslint 7.x, eslint-plugin-import #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynst
force-pushed
the
chore/eslint-plugin-import-migration
branch
from
ba19aad to
0d1ac45
Compare
Allow using BigNumber named export from bignumber.js (for now)
for now, allow: import axiosRetry from 'axios-retry' axiosRetry.exponentialDelay
dynst
force-pushed
the
chore/eslint-plugin-import-migration
branch
from
19f21a8 to
f4dfc11
Compare
Two conflicting exports both named 'Client'. One was a subclass of the other. Found by the 'import/export' lint.
dynst
force-pushed
the
chore/eslint-plugin-import-migration
branch
from
c31f35c to
dc9dd62
Compare
dynst
force-pushed
the
chore/eslint-plugin-import-migration
branch
from
141519c to
b88fcba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://typescript-eslint.io/blog/announcing-typescript-eslint-v7/
https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/#rule-breaking-changes
A big change upgrading from v5 is that import lints were dropped from
@typescript-eslint/6.x and newer in favor of the official eslint plugin.Disabling a few recommended lints in this PR, but a followup PR with code changes can turn them on again.
Real problems found:
import/exportparserOptions.projectwas left undefined, so while tsconfig.json files were being used in the build, they were never seen by eslint at all.The test files needed their own, separate tsconfig.json added. Without one, it complains if you run this:
xchainjs-lib/packages/xchain-bitcoin/package.json
Line 32 in b5b6bba
(And you can't add test files to the workspace's tsconfig.json, because it changes the inferred value for
rootDirfromsrc/to./, which changes typescript's build output fromlib/index.d.tstolib/src/index.d.ts.)