-
Notifications
You must be signed in to change notification settings - Fork 0
lin #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
usernamealreadyis
wants to merge
425
commits into
xccvv:darkfish_update
Choose a base branch
from
GistIcon:master
base: darkfish_update
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lin #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously RDoc::Options used OptionParser::DecimalInteger instead of Integer for restricting values for the tab width. Unfortunately the validator in RDoc uses #to_i to validate the input instead of Kernel#Integer. This means no exception is raised for invalid input such as "-w=3". Now Integer is used which has the strict validation but also allows octal, hexadecimal and binary numbers. Bug reported by Charles Hixson.
The people at techvision.net.in described this attribute as more for tabs or a chapter listing for a book. I think aria-controls will be sufficient.
The people at techvision.net.in said this is redundant since the main landmark is also used.
After extracting parse_comment_attr from parse_comment attr_reader and attr_writer broke as the type extracted from the directive was not used in the method. This broke due to insufficient tests in the parser.
If an alternate template is used it may not have the same static files (besides rdoc.css) so ignore such nonexistent static files.
Source Code Pro needs to be bold to stand out against Lato properly. Remove whitespace between method headings, it looks silly spread out all over the page.
Previously rdoc assumed rb_file_const was called within file.c, but this is not true in trunk. This caused the FNM_* constants to go missing. Now these constants appear in File::Constants as expected. (The constants do not appear in File even though File::Constants is included there, this is a limitation of other parts of RDoc.)
This interferes with some screen readers and is redundant according to the HTML 5 specification. Paragraph 4 here: http://www.whatwg.org/specs/web-apps/current-work/multipage/sections.html#the-article-element
The ids in the body of the HTML output now include the context of the heading to keep them unique, but this was not updated in the sidebar table of contents. Now the sidebar table of contents and the headings generate their labels from the same method, RDoc::Markup::Heading#label
This caused problems when an RDOCLINK was discovered inside a TIDYLINK. The ] wouldn't indicate the end of the RDOCLINK (any non-whitespace) so it would consume the ] and any following punctuation. This would cause a TIDYLINK to be unrecognized. The handling of markup inside a paragraph needs its own parser one of these days.
A user came through and capitalized all instances of "ruby" as that's not the proper way to do things. Since the commit came from the ruby repository it did not update the kpeg files (which are not included there). If the literals parsers are rebuilt in the future, now the "Ruby" fix won't regress.
This kpeg does not emit trailing whitespace which will prevent nobu from getting free commits when he cleans up whitespace in ruby trunk.
It provides the following features: * Loads translation messages from .po file. * Translates a message into the locale.
It provides the following features: * Extracts translation messages from wrapped raw text. * Translates wrapped raw text in specified locale.
The following options are added: * --locale * --locale-data-dir You can generate .pot (PO Template) file by the following command: % rdoc --format pot You can find .pot at doc/rdoc.pot. You can create .po from .pot by msginit provided by GNU gettext. Here is an example command line to generate .po for Japanese: % mkdir -p locale/ja % msginit --input doc/rdoc.pot --output-file locale/ja/rdoc.po --locale ja You can also use rmsginit provided by gettext gem instead of msginit: % mkdir -p locale/ja % rmsginit --input doc/rdoc.pot --output locale/ja/rdoc.po --locale ja rmsginit is implemented by pure Ruby. So it is more portable for Rubyists. .po should put locale/ja/rdoc.po or locale/ja.po. If there are both files, the former is used.
You can translate RDoc documentation by locale/#{LOCALE}/rdoc.po. For example, locale/ja/rdoc.po is for ja locale. If you have locale/ja/rdoc.po, you can generate documentation in Japanese by the following command: % rdoc --locale ja
It breaks Ruby 1.8 support.
Ruby 1.8's Hash doesn't have order.
Some PNGs has the execute bit set. Reset the execute bits for uniformity.
`Pathname#relative_path_from` raises an `ArgumentError` when the self path and the base directory have different prefixes, on Windows and DOSish systems which have drive letters (or UNC). The absolute path just works fine in that case.
`class C end` is now valid syntax
Fix for drive letters
Updated link to rake RDoc::Task.
Allow rdoc to run without gem
Do not store full path in GZipped js files.
Changed the default output directory of the rdoc task to 'doc'.
Fix ruby#362 Reported by Hans de Graaff. Thanks!!!
Revert "Changed the default output directory of the rdoc task to 'doc'."
…dated It's due to bug reverted in ruby/ruby@0516a33
…o-manifest Add missing i18n related files to manifest
Merge pull request #2 from GistIcon/master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the CoffeeLint engine for your project, add the following to your .codeclimate.yml configuration file:
Commit a .codeclimate.yml to the root of all branches in your repository.
Add an engines node.
Mark coffeelint as enabled: true.
engines: coffeelint: enabled: true