Skip to content

Conversation

addingama
Copy link
Contributor

  • Add additional props named showCallingCode
  • Add missing calling code for Antarctica

@xcarpentier
Copy link
Owner

xcarpentier commented Apr 12, 2018

👍

Could you please try to fix lint issues?

/home/ubuntu/react-native-country-picker-modal/src/CountryPicker.js
  329:1  error  Line 329 exceeds the maximum line length of 100  max-len

And regenerate jest snapshot: yarn test -u

@addingama
Copy link
Contributor Author

I don't know why I got this error when running the snapshot test

Cannot find module 'setupDevtools' from 'setup.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:179:17)
      at Object.<anonymous> (node_modules/react-native/jest/setup.js:30:1)

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files           5        5           
  Lines         103      103           
  Branches       17       17           
=======================================
  Hits           57       57           
  Misses         37       37           
  Partials        9        9
Impacted Files Coverage Δ
src/CountryPicker.js 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383a803...9c19d17. Read the comment docs.

@xcarpentier xcarpentier merged commit 63063ac into xcarpentier:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants