Fix HSP not displaying thumbnails from myfiles #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the gallery image is saved in myfiles, it is not served to Hereshpere. Heresphere will be passed a URL such as http://192.168.1.1:9999/img/700x//myfiles/image.jpg. This fails as the imageproxy package, by default, expects an absolute Url.
I have changed the imageproxy setup to use a default base Url that points back to XBVR so something http://192.168.1.1:9999/img/700x//myfiles/image.jpg will be treated as http://192.168.1.1:9999/img/700x/http://127.0.0.1:9999/myfiles/image.jpg (or whatever port you have configured)
I have also updated the GetImageUrl in details.vue, some it always returns a url, if the image url did not start with "http", then no url is returned from the functioon