Remove column on drop_constraint

Signed-off-by: Alexis Rico <sferadev@gmail.com>
xataio · Nov 5, 2024 · 39cb2ae · 39cb2ae
1 parent b7f264b
commit 39cb2ae
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/.changeset/forty-shirts-hug.md b/.changeset/forty-shirts-hug.md
@@ -0,0 +1,5 @@
+---
+'@xata.io/pgroll': minor
+---
+
+[Breaking] Remove `column` from `drop_constraint`
diff --git a/packages/cli/src/commands/schema/edit.test.ts b/packages/cli/src/commands/schema/edit.test.ts
@@ -441,7 +441,6 @@ const testCases: TestCase[] = [
           table: 'table2',
           down: '"col1"',
           up: '"col1"',
-          column: 'col1',
           name: 'table2_col1_unique'
         }
       }

diff --git a/packages/cli/src/commands/schema/edit.ts b/packages/cli/src/commands/schema/edit.ts
@@ -962,7 +962,6 @@ export const editsToMigrations = (command: EditSchema) => {
               ? {
                   drop_constraint: {
                     table: tableName,
-                    column: originalField.name,
                     name: uniqueConstraintName,
                     up: `"${originalField.name}"`,
                     down: `"${originalField.name}"`

diff --git a/packages/pgroll/src/schema.ts b/packages/pgroll/src/schema.ts
@@ -329,10 +329,6 @@ export const schema = {
       additionalProperties: false,
       description: 'Drop constraint operation',
       properties: {
-        column: {
-          description: 'Name of the column',
-          type: 'string'
-        },
         down: {
           default: '',
           description: 'SQL expression for down migration',
@@ -351,7 +347,7 @@ export const schema = {
           type: 'string'
         }
       },
-      required: ['column', 'down', 'name', 'table', 'up'],
+      required: ['down', 'name', 'table', 'up'],
       type: 'object'
     },
     OpDropIndex: {

diff --git a/packages/pgroll/src/types.ts b/packages/pgroll/src/types.ts
@@ -90,7 +90,6 @@ export const OpDropColumnDefinition = z.object({
 export type OpDropConstraint = z.infer<typeof OpDropConstraintDefinition>;
 
 export const OpDropConstraintDefinition = z.object({
-  column: z.string(),
   down: z.string(),
   name: z.string(),
   table: z.string(),