Monitoring: NodeSDK + Otel + Langfuse #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an alternative monitoring implementation using the NodeSDK with OpenTelemetry and Langfuse while removing the dependency on the @vercel/otel package. Key changes include:
- Adding experimental telemetry configuration blocks to various generate* calls across multiple modules.
- Integrating telemetry metadata into the playbook, chat artifact, and monitoring functions.
- Introducing NodeSDK instrumentation in the instrumentation files and updated Docker compose configuration for Langfuse.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/dbagent/src/lib/monitoring/runner.ts | Adds telemetry metadata for notifications, playbook, and summary prompts. |
| apps/dbagent/src/lib/ai/tools/artifacts.ts | Integrates telemetry metadata into the suggestion request tool. |
| apps/dbagent/src/components/playbooks/action.ts | Introduces telemetry metadata for playbook content generation. |
| apps/dbagent/src/components/monitoring/actions.ts | Adds telemetry metadata for generating cron expressions. |
| apps/dbagent/src/components/chat/artifacts/text/server.ts | Applies telemetry metadata for text artifact creation and updates. |
| apps/dbagent/src/components/chat/artifacts/sheet/server.ts | Applies telemetry metadata for sheet artifact creation and updates. |
| apps/dbagent/src/app/api/chat/route.ts | Includes telemetry metadata with detailed connection and model info in the chat API. |
| apps/dbagent/src/app/(main)/projects/[project]/chats/actions.ts | Adds telemetry metadata for generating chat titles. |
| apps/dbagent/instrumentation.ts & instrumentation-node.ts | Introduces NodeSDK instrumentation using OpenTelemetry and Langfuse. |
| apps/dbagent/dev/langfuse/docker-compose.yml | Updates configuration for Langfuse and related services. |
Files not reviewed (2)
- apps/dbagent/package.json: Language not supported
- apps/dbagent/tsconfig.json: Language not supported
Comment on lines
+94
to
+99
| experimental_telemetry: { | ||
| isEnabled: true, | ||
| metadata: { | ||
| tags: ['monitoring', 'notification'] | ||
| } | ||
| } |
There was a problem hiding this comment.
[nitpick] The experimental_telemetry block is repetitively added in multiple functions. Consider extracting the common telemetry metadata structure into a helper function or constant to improve maintainability and reduce duplication.
Suggested change
| experimental_telemetry: { | |
| isEnabled: true, | |
| metadata: { | |
| tags: ['monitoring', 'notification'] | |
| } | |
| } | |
| experimental_telemetry: EXPERIMENTAL_TELEMETRY |
Contributor
Author
There was a problem hiding this comment.
Well, this is to be expected.
This was referenced May 6, 2025
SferaDev
approved these changes
May 8, 2025
Member
|
Vercel OTEL has some extra tracers that we might want to add but we can do it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #156
This change uses the NodeSDK and does not rely on @vercel/otel package. On the plus side, I haven't had to fight version incompatibilities between a few packages.