Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates
xvecwithxproj(see xarray-contrib/xproj#27 for more context).From the Xvec's user point of view there's no change, apart from:
xprojbecoming a required dependencyThere's a few more details in the commit messages.
I added a couple of tests in
test_xproj_integration.py, which illustrate howxvecandxprojmay be used together. I can also add those examples in the documentation, although maybe it'd be safer to wait a bit untilxprojbecomes a bit more mature? I plan to add similar examples inxproj's documentation anyway.