Skip to content

Conversation

@Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 16, 2024

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is just a guideline):

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

[summarize your pull request here]

Changes

  • Split the development requirements into a requirements-dev.txt file, added coverage-related dependencies
  • Added a configuration for pytest to run with coverage testing to setup.cfg
  • Updated the testing CI main.yml (previously python-app.yml) to perform a development install and check version compatibility
  • Added a note in the publishing workflow about deployment environments.

@Zeitsperre Zeitsperre added the enhancement New feature or request label Feb 16, 2024
@Zeitsperre Zeitsperre requested a review from huard February 16, 2024 20:54
@Zeitsperre Zeitsperre self-assigned this Feb 16, 2024
@Zeitsperre
Copy link
Collaborator Author

@huard

To close this, you'll need to change the required checks to remove build (3.10) and set it to require the Coverall Report job. The last step will be to add the Coveralls.io webhook (can be done by going to https://coveralls.io/repos/new and enabling xncml).

@huard huard merged commit 02c4d13 into main Mar 4, 2024
@huard huard deleted the coverage-ci branch March 4, 2024 13:28
@huard huard mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants