Skip to content

Conversation

@abel-bzz
Copy link
Collaborator

@abel-bzz abel-bzz commented Dec 12, 2023

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

This PR fixes #61

Abel Aoun added 3 commits December 12, 2023 19:06
The new schema comes from netCDF-java repository directly.
Also regenerate generated files and adapt code.
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the scalar handling will break code that previously expected sequences for everything. Please mention it loud and clear in the CHANGELOG.

@abel-bzz
Copy link
Collaborator Author

Yes and it might break when the values.content is empty too.
Maybe I should split that into another Issue and PR.

@abel-bzz
Copy link
Collaborator Author

abel-bzz commented Jan 4, 2024

I refactored the scalar handling to included more cases and added related integration tests. I also documented the changes but prior to 0.4.0, scalar variables were not handled at all so it's not really a breaking changes more a new feature.

@abel-bzz abel-bzz requested a review from huard January 4, 2024 12:42
@huard huard merged commit e8cabb7 into xarray-contrib:main Jan 8, 2024
@abel-bzz abel-bzz deleted the enh/update_xsd branch January 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated xsd

2 participants