Skip to content

Conversation

@abel-bzz
Copy link
Collaborator

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is just a guideline):

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

[summarize your pull request here]

Changes

  • Make it possible to parse EnumTypeDef and turn the enums into CF flag_values and flag_meanings.
  • Also add support for scalar variable (when shape is empty)

References

I. For Enum type conversion: from common_data_model_overview

There are 3 enum types: enum1, enum2, and enum4, corresponding to storing the integer as a byte, short, or int.

II. For scalar variable: from annotated_ncml_schema

The shape attribute lists the names of the dimensions the variable depends on. For a scalar variable, the list will be empty.

@huard
Copy link
Collaborator

huard commented Dec 12, 2023

All good, could you add a note in the CHANGELOG, under a new 0.4 release ?

@abel-bzz
Copy link
Collaborator Author

All good, could you add a note in the CHANGELOG, under a new 0.4 release ?

Oops I did it and forgot to push the commit

@huard huard merged commit 12df2df into xarray-contrib:main Dec 12, 2023
@abel-bzz abel-bzz deleted the enh/add_enum_support branch December 12, 2023 17:03
@abel-bzz abel-bzz mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants