less strict iframe options #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for xarraydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Indeed seems to have fixed it: https://deploy-preview-814--xarraydev.netlify.app/blog/flox |
|
thanks Ian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #813 (though im not sure if the build config will affect the PR build)
by allowing linking of iframes from anywhere, and anywhere to link an iframe of us. we could also change it to
SAMEORIGINto allow us to use iframes internally, but no one can make an iframe of us. But I like this more permissive model, it would have made it easier for me to embed the xarray repr from this site in the post i wrote on the napari blog.I also removed
X-XSS-PROTECTIONwhich is non-standard, deprecated and recommended to be removed: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/X-XSS-Protectionheads up to @scottyhq if you have opinions here