Parametrize over different reduction operations #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Aug 22, 2024
| @@ -12,22 +13,15 @@ class ReductionTests(DuckArrayTestMixin): | |||
| def expected_errors(op, **parameters): | |||
| return nullcontext() | |||
|
|
|||
| @pytest.mark.parametrize("op", ["mean", "sum", "prod", "std", "var"]) | |||
There was a problem hiding this comment.
One of "min" or "max" would be good for checking that dtype is preserved. I'm not sure "std" adds much over "var".
There was a problem hiding this comment.
These were really just chosen in order to cover some known bugs with cubed. Specifically that cubed doesn't yet implement std or var, and the array API standard only requires mean to work with floats, not integers.
Eventually we would want a test suite that covers everything, this is just meant to be a proof-of-principle for discussing overall design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.