support for "no unit" values #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a pint.Unit instance directly will create it from the default registry, so the first and second TODO comments actually referred to the same issue. We also decided to have specific packages (i.e. cf-xarray) provide the unit registry.
|
|
Member
Author
fine with me. Seems like we shouldn't put this in |
TomNicholas
reviewed
Jul 23, 2021
Member
TomNicholas
left a comment
TomNicholas
left a comment
There was a problem hiding this comment.
Thanks @keewis - the only other thing I would add is some kind of example or note in the documentation to show this feature, beyond just the note in the quantify docstring.
Member
Author
|
great, let's merge. I'll try to create a few more PRs with small fixes, merge #110 and then issue a minor release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the internal use of
Noneas a "no unit" value and adds the new values requested in #118 (I skipped the integer1for now but it should be a single line change to add it).cc @dcherian, @jbusecke
pre-commit run --all-fileswhats-new.rstNew functions/methods are listed inapi.rst