Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Breakages with changes to xarray's internals during the NamedArray refactor #270

Closed
TomNicholas opened this issue Oct 24, 2023 · 3 comments

Comments

@TomNicholas
Copy link
Member

So far datatree appears to have got away with cheekily importing and using many private xarray internals, but soon things will start breaking.

@andersy005 is hard at work refactoring xarray to split out the internal Variable class as a new stand-alone object, NamedArray.

These changes will definitely break datatree at some point soon, if only because private xarray utility functions will be imported from different places within xarray's codebase.

The long-term solution to this is to get on with integrating everything in datatree into xarray upstream. In the short-term we probably do not want to try and do that integration until the NamedArray refactor has progressed further, so there will be at least some versions of xarray for which datatree breaks (probably the next xarray version to be released).

@Illviljan
Copy link

How about pinning xarray to a working version and making a quick release?

@TomNicholas
Copy link
Member Author

Okay this anticipated issue seems to have now manifested.

How about pinning xarray to a working version and making a quick release?

Seems like a good idea.

@TomNicholas
Copy link
Member Author

The long-term solution to this is to get on with integrating everything in datatree into xarray upstream.

That's what we've been doing, so I'm closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants