Add conversion between shapely and cf for polygons #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 13 13
Lines 2279 2364 +85
Branches 172 183 +11
=======================================
+ Hits 1955 2028 +73
- Misses 294 303 +9
- Partials 30 33 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
aulemahal
approved these changes
Jan 18, 2024
jsignell
commented
Jan 19, 2024
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
jsignell
commented
Jan 19, 2024
|
Ok @dcherian I think this one is good to go! |
|
Thanks Julia! Can we have you on board as a maintainer please/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #460 now with polygons!
There is a slight wrinkle in that unlike shapely cf doesn't seem to associate particular holes with particular polygons. I am kind of assuming that the order will be interleaved exterior and interior rings. This seem to match the examples that I've seen.