Skip to content

Conversation

@dcherian
Copy link
Contributor

@dcherian dcherian commented May 3, 2023

Closes #422

cc @Zeitsperre

@dcherian dcherian requested a review from malmans2 May 3, 2023 21:35
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #436 (89f1321) into main (2d579f2) will increase coverage by 58.97%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #436       +/-   ##
===========================================
+ Coverage   37.35%   96.33%   +58.97%     
===========================================
  Files          21       21               
  Lines        3916     2839     -1077     
  Branches      194        0      -194     
===========================================
+ Hits         1463     2735     +1272     
+ Misses       2259      104     -2155     
+ Partials      194        0      -194     
Flag Coverage Δ
mypy ?
unittests 96.33% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/accessor.py 94.81% <ø> (+58.84%) ⬆️
cf_xarray/tests/__init__.py 65.95% <100.00%> (+46.80%) ⬆️
cf_xarray/tests/test_accessor.py 99.80% <100.00%> (+70.62%) ⬆️
cf_xarray/utils.py 88.57% <100.00%> (+58.57%) ⬆️

... and 18 files with indirect coverage changes

Copy link
Member

@malmans2 malmans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I would just change the docstring of argument source in add_canonical_attributes, to something like:

If None, use the latest CF standard name table.

@malmans2
Copy link
Member

malmans2 commented May 4, 2023

Another quick comment, if we use fsspec rather than pooch, I think it's more likely that it is already installed as it should be a dependency of dask.
See: #422 (comment)

@Zeitsperre
Copy link
Contributor

@dcherian Thanks for the heads up!

@dcherian dcherian enabled auto-merge (squash) May 4, 2023 21:05
@dcherian
Copy link
Contributor Author

dcherian commented May 4, 2023

if we use fsspec rather than pooch, I think it's more likely that it is already installed as it should be a dependency of dask.

I think its OK. Xarray uses pooch for its tutorial datasets anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use pooch for the CF standard name table

3 participants