-
Notifications
You must be signed in to change notification settings - Fork 42
Use pooch instead of bundling standard name table #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
===========================================
+ Coverage 37.35% 96.33% +58.97%
===========================================
Files 21 21
Lines 3916 2839 -1077
Branches 194 0 -194
===========================================
+ Hits 1463 2735 +1272
+ Misses 2259 104 -2155
+ Partials 194 0 -194
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I would just change the docstring of argument source in add_canonical_attributes, to something like:
If None, use the latest CF standard name table.
|
Another quick comment, if we use |
|
@dcherian Thanks for the heads up! |
I think its OK. Xarray uses pooch for its tutorial datasets anyway... |
Closes #422
cc @Zeitsperre