Skip to content

Conversation

@larsbuntemeyer
Copy link
Contributor

closes #425

This PR updates criteria and regex for identifying X and Y axis in rotated pole grids.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #426 (d237087) into main (ce9cd5a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   86.37%   86.39%   +0.02%     
==========================================
  Files          22       22              
  Lines        3977     3983       +6     
  Branches      191      191              
==========================================
+ Hits         3435     3441       +6     
  Misses        490      490              
  Partials       52       52              
Flag Coverage Δ
mypy 37.33% <83.33%> (+0.09%) ⬆️
unittests 96.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cf_xarray/criteria.py 99.05% <100.00%> (+0.05%) ⬆️
cf_xarray/tests/test_accessor.py 93.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dcherian
Copy link
Contributor

Looks great!

@dcherian dcherian merged commit 3885b44 into xarray-contrib:main Feb 27, 2023
@larsbuntemeyer larsbuntemeyer deleted the X_Y_detect branch February 28, 2023 21:14
@larsbuntemeyer
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

identify rlon/rlat as X/Y

2 participants