Skip to content

Conversation

@lindig
Copy link
Contributor

@lindig lindig commented Feb 28, 2024

Backport of 9ea53a0d033d1f76b1d2f35e59d7b61669db7d46 in xen-api.git. The code on the master branch is organised differently. Hence, this is a manual backport of the implementation.

When xenopsd-xc getting process id of a service, verify that its commandline items include expected process name and some commandline arg containing domid if domid is not part of its process name.

@lindig lindig requested review from gangj and robhoes February 28, 2024 10:47
Copy link
Member

@robhoes robhoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangj
Copy link

gangj commented Feb 29, 2024

Another minor one not exists here:

@@ -913,7 +953,7 @@ module PV_Vnc = struct
     let l =
       [
         "-x"
-      ; Printf.sprintf "/local/domain/%d/console" domid
+      ; vnc_console_path domid
       ; "-T"
       ; (* listen for raw connections *)
         "-v"

Backport of 9ea53a0d033d1f76b1d2f35e59d7b61669db7d46 in xen-api.git.
The code on the master branch is organised differently. Hence, this is a
manual backport of the implementation.

When xenopsd-xc getting process id of a service, verify that its
commandline items include expected process name and some commandline
arg containing domid if domid is not part of its process name.

Signed-off-by: Gang Ji <gang.ji@citrix.com>
Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
@lindig lindig merged commit c4d0460 into xapi-project:0.150-lcm Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants