CP-41796 Close Port 80 (Encrypt Data Transfer During VM Migrations) #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of several commits; we omit those that in the original code deal with certificate checking as this is not present in this code base. The original code is in xen-api.git but in the backport is split into xe-api.git, xenopsd.git, and xen-api-libs-transitional.git. Socket keepalives do not work when stunnel is used, as the given fd is the local connection to stunnel, and are not set in HTTPS mode. This is fine, because the stunnel client is already set up with keepalives. Signed-off-by: Christian Lindig <christian.lindig@citrix.com> Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
Add a local modified copy of with_open_uri to avoid a circular dependency with xcp-idl. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
Add modified copies of * open_uri * xcp_client to handle https URIs. This can't be done in the original module in xcp-idl as it would introduce a circular dependency. Signed-off-by: Christian Lindig <christian.lindig@cloud.com>
psafont
approved these changes
Mar 17, 2023
robhoes
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of several commits; we omit those that in the original code deal with certificate checking as this is not present in this code base.
The original code is in xen-api.git but in the backport is split into xe-api.git, xenopsd.git, and xen-api-libs-transitional.git.
Socket keepalives do not work when stunnel is used, as the given fd is the local connection to stunnel, and are not set in HTTPS mode. This is fine, because the stunnel client is already set up with keepalives.