Skip to content

CA-369444: Ensure xenopsd still starts if VM state upgrade fails #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023
Merged

CA-369444: Ensure xenopsd still starts if VM state upgrade fails #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/xenops_server.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3562,8 +3562,15 @@ let upgrade_internal_state_of_running_vms () =
let module B = (val get_backend () : S) in
List.iter
(fun vm ->
let vm_t = VM_DB.read_exn vm in
B.VM.get_internal_state [] [] vm_t |> B.VM.set_internal_state vm_t
try
let vm_t = VM_DB.read_exn vm in
B.VM.get_internal_state [] [] vm_t |> B.VM.set_internal_state vm_t
with
| Xenops_interface.Xenopsd_error (Does_not_exist _) ->
warn "Missing VM extra metadata for VM %s" vm
| e ->
warn "VM metadata upgrade failed for VM %s (%s)" vm
(Printexc.to_string e)
)
(VM_DB.ids ())

Expand Down